Features/tcg-multithread: Difference between revisions
No edit summary |
No edit summary |
||
Line 22: | Line 22: | ||
==Problems to keep in mind== | ==Problems to keep in mind== | ||
===Memory consistency=== | |||
Host and guest might implement different memory consistency models. | |||
===Instruction atomicity=== | |||
Atomic instructions must be translated to an atomic host operation. | |||
I'd suggest the following refinement sequence: | |||
* add the concept of memory coherence domains (MCD) in QEMU with a lock on each (can start with a system-wide MCD) | |||
* wrap every instruction with the lock of the corresponding MCD | |||
* remove locking for non-atomic instructions | |||
* add atomic primitives in TCG (should have MCD as argument), translating them to using the appropriate lock | |||
* optimize TCG atomics to use atomic instructions on the host | |||
Revision as of 19:11, 26 November 2014
MultiThreaded support in the TCG
Improving TCG performance
OverView
Qemu can currently emulate a number of CPU’s in parallel, but it does so in a single thread. Given many modern hosts are multi-core, and many targets equally use multiple cores, a significant performance advantage can be realised by making use of multiple host threads to simulate multiple target cores.
This is work in progress - we expect to publish results on this wiki page as progress is made.
Plan
The TCG today is close to being thread safe, but there is still some concern that there are remaining issues. We will address this by first focusing on user-level TCG threads as this seems a straightforward target. Subsequently the wider case of system level multi-threading will be looked at. The following is an currently incomplete list of issues to address:
Global TCG State
Currently there is no protection against two threads attempting to generate code at the same time into the translation buffer. This means you do see corrupted code generation from time to time in multi-threaded apps. There are a couple of approaches we could take from adding locking to the code generator so only one thread at a time could generate code to having separate translation buffers for each thread of execution.
There are also a number of global variables and assumptions in the various back-ends which will need to audited. I suspect these values will need to be wrapped up in a portable TCGContext.
Signal Handling
There are two types of signal we need to handle. Synchronous (e.g. SIGBUS, SIGSEG) and Asynchronous (e.g. SIGSTOP, SIGINT, SIGUSR). While any signal can be sent asynchronously most of the common synchronous ones occur when there is an error in the translated code. As such rectifying machine state is fairly well tested. For Asynchronus signals there are a plethora of edge cases to deal with especially around the handling of signals with respect to system calls. If they arrive during translated code there behaviour is fairly easy to handle however when in QEMU's own code care has to be taken that syscalls respond correctly to the EINTR.
Problems to keep in mind
Memory consistency
Host and guest might implement different memory consistency models.
Instruction atomicity
Atomic instructions must be translated to an atomic host operation.
I'd suggest the following refinement sequence:
- add the concept of memory coherence domains (MCD) in QEMU with a lock on each (can start with a system-wide MCD)
- wrap every instruction with the lock of the corresponding MCD
- remove locking for non-atomic instructions
- add atomic primitives in TCG (should have MCD as argument), translating them to using the appropriate lock
- optimize TCG atomics to use atomic instructions on the host
How to get involved
Right now, there is a small dedicated team looking at this issue. Those are:
- Fred Konrad
- Mark Burton
- Pavel Dovgaluk
If you would like to be involved, please use the qemu-devel mail list.
We will run phone conference calls as appropriate to co-ordinate activity and we will feed back to the main Qemu mail lists as progress is made.
Other Work
This is the most important section initially, and we welcome any, and all comments and other work. If you know of any patch sets that may be of value, PLEASE let us know via the qemu-devel mail list.
Proof of concept implementations
Below are all the proof of concept implementations we have found thus far. It is highly likely that some of these patch sets can help us to reach an up-streamable solution. At the very least these provide some evidence that there is a performance improvement to be had.
http://dl.acm.org/citation.cfm?id=2259030&CFID=454906387&CFTOKEN=60579010 https://github.com/podinx/PQEMU http://www.cs.nthu.edu.tw/~ychung/conference/ICPADS2011.pdf