Contribute/SubmitAPatch: Difference between revisions
No edit summary |
No edit summary |
||
| Line 5: | Line 5: | ||
'''Patch emails must include a Signed-off-by: line'''. For more information see [http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 SubmittingPatches 1.12]. | '''Patch emails must include a Signed-off-by: line'''. For more information see [http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 SubmittingPatches 1.12]. | ||
Make sure to '''follow the coding style''': | Make sure to '''follow the coding style''' by running ''scripts/checkpatch.pl <patchfile>'' before submitting patches: | ||
* [http://git.qemu.org/qemu.git/plain/CODING_STYLE QEMU Coding Style] | * [http://git.qemu.org/qemu.git/plain/CODING_STYLE QEMU Coding Style] | ||
* [http://git.qemu.org/qemu.git/plain/HACKING QEMU Coding Guidelines] | * [http://git.qemu.org/qemu.git/plain/HACKING QEMU Coding Guidelines] | ||
Revision as of 09:11, 19 July 2011
All contributions to QEMU are sent as patches to the qemu-devel mailing list. Patch contributions should not be posted on the bug tracker, posted on forums, or externally hosted and linked to.
Send patches inline so they are easy to reply to with review comments. Do not put patches in attachments.
Patch emails must include a Signed-off-by: line. For more information see SubmittingPatches 1.12.
Make sure to follow the coding style by running scripts/checkpatch.pl <patchfile> before submitting patches:
Split up longer patches into a patch series of logical code changes. Each change should compile and execute successfully.
For smaller patches in less frequently changed areas of QEMU, consider using the trivial patches process.