Contribute/SubmitAPatch: Difference between revisions

From QEMU
(Created page with '== Submitting patches == All contributions to QEMU are sent as patches to the qemu-devel mailing list. Send patches inline so they are easy to reply to with re…')
 
Line 1: Line 1:
== Submitting patches ==
'''All contributions to QEMU are sent as patches to the qemu-devel [[MailingLists|mailing list]]'''.


All contributions to QEMU are sent as patches to the qemu-devel [[MailingLists|mailing list]].
'''Send patches inline''' so they are easy to reply to with review comments.  Do not put patches in attachments.


Send patches inline so they are easy to reply to with review commentsDo not put patches in attachments.
'''Patch emails must include a Signed-off-by: line'''For more information see [http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 SubmittingPatches 1.12].


Patch emails must include a Signed-off-by: line.  For more information see [http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 SubmittingPatches 1.12].
Make sure to '''follow the coding style''':
 
Make sure to follow the coding style:
* [http://git.qemu.org/qemu.git/plain/CODING_STYLE QEMU Coding Style]
* [http://git.qemu.org/qemu.git/plain/CODING_STYLE QEMU Coding Style]
* [http://git.qemu.org/qemu.git/plain/HACKING QEMU Coding Guidelines]
* [http://git.qemu.org/qemu.git/plain/HACKING QEMU Coding Guidelines]


Split up longer patches into a patch series of logical code changes.  Each change should compile and execute successfully.
'''Split up longer patches into a patch series of logical code changes'''.  Each change should compile and execute successfully.

Revision as of 09:59, 6 January 2011

All contributions to QEMU are sent as patches to the qemu-devel mailing list.

Send patches inline so they are easy to reply to with review comments. Do not put patches in attachments.

Patch emails must include a Signed-off-by: line. For more information see SubmittingPatches 1.12.

Make sure to follow the coding style:

Split up longer patches into a patch series of logical code changes. Each change should compile and execute successfully.