Contribute/SubmitAPatch: Difference between revisions

From QEMU
(Undo revision 1875 by Hx110912 (Talk))
(Replaced content with "Moved at https://www.qemu.org/docs/master/devel/submitting-a-patch.html")
Tag: Replaced
 
(76 intermediate revisions by 14 users not shown)
Line 1: Line 1:
All contributions to QEMU are '''sent as patches''' to the qemu-devel [[MailingLists|mailing list]].  Patch contributions should not be posted on the bug tracker, posted on forums, or externally hosted and linked to.
Moved at https://www.qemu.org/docs/master/devel/submitting-a-patch.html
 
You get a better chance to get a reply if you follow the LKML rule of send directly to the maintainer of the portion of the patch (see MAINTAINERS file). Also keep attention to reply to all and not just the sender.
 
Consider also to prefix your patch commit messages with the portion you changed (ie: block or tcg).
 
'''Send patches inline''' so they are easy to reply to with review comments.  Do not put patches in attachments.
 
'''Patch emails must include a Signed-off-by: line'''.  For more information see [http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 SubmittingPatches 1.12].
 
'''Follow the coding style''' and run ''scripts/checkpatch.pl <patchfile>'' before submitting.  See also:
* [http://git.qemu.org/qemu.git/plain/CODING_STYLE QEMU Coding Style]
* [http://git.qemu.org/qemu.git/plain/HACKING QEMU Coding Guidelines]
 
'''Split up longer patches''' into a patch series of logical code changes.  Each change should compile and execute successfully.
 
For smaller patches in less frequently changed areas of QEMU, consider using the [[Contribute/TrivialPatches|trivial patches]] process.

Latest revision as of 07:32, 18 November 2021