Contribute/SubmitAPatch: Difference between revisions

Revision as of 13:16, 20 July 2011

All contributions to QEMU are sent as patches to the qemu-devel mailing list. Patch contributions should not be posted on the bug tracker, posted on forums, or externally hosted and linked to.

Send patches inline so they are easy to reply to with review comments. Do not put patches in attachments.

Patch emails must include a Signed-off-by: line. For more information see SubmittingPatches 1.12.

Follow the coding style and run scripts/checkpatch.pl <patchfile> before submitting. See also:

Split up longer patches into a patch series of logical code changes. Each change should compile and execute successfully.

For smaller patches in less frequently changed areas of QEMU, consider using the trivial patches process.

@@ Line 1: / Line 1: @@
-This nicely protected goblet marketplace http://www.pandorasalesbracelet.com/pandora-murano-glass-beads.html ongoing to thrive right up until the seventeenth century, at which place it started to undergo a slow decline. Political environment http://www.pandorasalesbracelet.com/pandora-bracelets-necklaces.html changed, Venetian Republic fell, and countless new goblet producing centers emerged producing it difficult for Murano http://www.pandorasalesbracelet.com/pandora-sale.html  to compete. However, the appreciatio n http://www.pandorasalesbracelet.com/pandora-jewellery.html commitment within of the artisans to  http://www.pandorasalesbracelet.com/pandora-gold-beads-charms.html their craft and family people traditions prevented Murano goblet
+All contributions to QEMU are '''sent as patches''' to the qemu-devel [[MailingLists|mailing list]].  Patch contributions should not be posted on the bug tracker, posted on forums, or externally hosted and linked to.
+'''Send patches inline''' so they are easy to reply to with review comments.  Do not put patches in attachments.
+'''Patch emails must include a Signed-off-by: line'''.  For more information see [http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 SubmittingPatches 1.12].
+'''Follow the coding style''' and run ''scripts/checkpatch.pl <patchfile>'' before submitting.  See also:
+* [http://git.qemu.org/qemu.git/plain/CODING_STYLE QEMU Coding Style]
+* [http://git.qemu.org/qemu.git/plain/HACKING QEMU Coding Guidelines]
+'''Split up longer patches''' into a patch series of logical code changes.  Each change should compile and execute successfully.
+For smaller patches in less frequently changed areas of QEMU, consider using the [[Contribute/TrivialPatches|trivial patches]] process.